Skip to content

🌱 Bump golangci-lint to v2.6.2#601

Merged
metal3-io-bot merged 1 commit intometal3-io:release-0.6from
Nordix:bump/golangci-lint-v2.6.2-release-0.6
Mar 19, 2026
Merged

🌱 Bump golangci-lint to v2.6.2#601
metal3-io-bot merged 1 commit intometal3-io:release-0.6from
Nordix:bump/golangci-lint-v2.6.2-release-0.6

Conversation

@kashifest
Copy link
Member

@kashifest kashifest commented Mar 17, 2026

Manual cherry-pick of #438

Fixes #

Checklist:

  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • E2E tests have been added, if necessary.

@metal3-io-bot metal3-io-bot added this to the IrSO - v0.6 milestone Mar 17, 2026
@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 17, 2026
@Rozzii
Copy link
Member

Rozzii commented Mar 17, 2026

Just to make sure.
/retest

@kashifest
Copy link
Member Author

kashifest commented Mar 17, 2026 •
edited
Loading

I have no clue why this is failing now
any pointers @tuminoid @dtantsur @Rozzii ?

tuminoid
tuminoid reviewed Mar 17, 2026
View reviewed changes
@dtantsur
Copy link
Member

dtantsur commented Mar 17, 2026

The test failed because of the ramdisk downloader, which should be fixed now.

@Rozzii
Copy link
Member

Rozzii commented Mar 18, 2026

/retest

@tuminoid
Copy link
Member

tuminoid commented Mar 18, 2026

The test failed because of the ramdisk downloader, which should be fixed now.

If it keeps failing, please rebase rather than retrigger the test.

@kashifest kashifest force-pushed the bump/golangci-lint-v2.6.2-release-0.6 branch 2 times, most recently from 80ba2a9 to 8068a52 Compare March 18, 2026 10:57
@nuhakala @kashifest
Bump golangci-lint to v2 and fix issues
b00e520 
Signed-off-by: Nuutti Hakala <nuutti.hakala@est.tech>
Signed-off-by: Kashif Khan <kashif.khan@est.tech>
@kashifest kashifest force-pushed the bump/golangci-lint-v2.6.2-release-0.6 branch from 8068a52 to b00e520 Compare March 18, 2026 11:07
tuminoid
tuminoid reviewed Mar 18, 2026
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2026
@kashifest
Copy link
Member Author

kashifest commented Mar 18, 2026

The test failed because of the ramdisk downloader, which should be fixed now.

I have rebased but the IPA download speed is still a blocker it seems, this is after 42 minutes

 67  499M   67  335M    0     0   137k      0  1:01:46  0:41:30  0:20:16 22036
 67  499M   67  335M    0     0   137k      0  1:01:47  0:41:31  0:20:16 23432
 67  499M   67  335M    0     0   137k      0  1:01:48  0:41:32  0:20:16 29628
 67  499M   67  335M    0     0   137k      0  1:01:49  0:41:33  0:20:16 31868
 67  499M   67  335M    0     0   137k      0  1:01:51  0:41:34  0:20:17 28298
 67  499M   67  335M    0     0   137k      0  1:01:52  0:41:35  0:20:17 24134
 67  499M   67  335M    0     0   137k      0  1:01:53  0:41:36  0:20:17 22995
 67  499M   67  335M    0     0   137k      0  1:01:54  0:41:37  0:20:17 25859
 67  499M   67  335M    0     0   137k      0  1:01:55  0:41:38  0:20:17 29353
 67  499M   67  335M    0     0   137k      0  1:01:56  0:41:39  0:20:17 39215
 67  499M   67  335M    0     0   137k      0  1:01:57  0:41:40  0:20:17 50048
 67  499M   67  335M    0     0   137k      0  1:01:57  0:41:41  0:20:16 63581
 67  499M   67  335M    0     0   137k      0  1:01:58  0:41:42  0:20:16 72518
 67  499M   67  336M    0     0   137k      0  1:01:58  0:41:43  0:20:15 85928
 67  499M   67  336M    0     0   137k      0  1:01:58  0:41:44  0:20:14  100k
 67  499M   67  336M    0     0   137k      0  1:01:59  0:41:46  0:20:13 97123
 67  499M   67  336M    0     0   137k      0  1:02:00  0:41:46  0:20:14 88702

@kashifest
Copy link
Member Author

kashifest commented Mar 19, 2026

/cc @Rozzii

@tuminoid
Copy link
Member

tuminoid commented Mar 19, 2026

The test failed because of the ramdisk downloader, which should be fixed now.

I have rebased but the IPA download speed is still a blocker it seems, this is after 42 minutes

 67  499M   67  335M    0     0   137k      0  1:01:46  0:41:30  0:20:16 22036
 67  499M   67  335M    0     0   137k      0  1:01:47  0:41:31  0:20:16 23432
 67  499M   67  335M    0     0   137k      0  1:01:48  0:41:32  0:20:16 29628
 67  499M   67  335M    0     0   137k      0  1:01:49  0:41:33  0:20:16 31868
 67  499M   67  335M    0     0   137k      0  1:01:51  0:41:34  0:20:17 28298
 67  499M   67  335M    0     0   137k      0  1:01:52  0:41:35  0:20:17 24134
 67  499M   67  335M    0     0   137k      0  1:01:53  0:41:36  0:20:17 22995
 67  499M   67  335M    0     0   137k      0  1:01:54  0:41:37  0:20:17 25859
 67  499M   67  335M    0     0   137k      0  1:01:55  0:41:38  0:20:17 29353
 67  499M   67  335M    0     0   137k      0  1:01:56  0:41:39  0:20:17 39215
 67  499M   67  335M    0     0   137k      0  1:01:57  0:41:40  0:20:17 50048
 67  499M   67  335M    0     0   137k      0  1:01:57  0:41:41  0:20:16 63581
 67  499M   67  335M    0     0   137k      0  1:01:58  0:41:42  0:20:16 72518
 67  499M   67  336M    0     0   137k      0  1:01:58  0:41:43  0:20:15 85928
 67  499M   67  336M    0     0   137k      0  1:01:58  0:41:44  0:20:14  100k
 67  499M   67  336M    0     0   137k      0  1:01:59  0:41:46  0:20:13 97123
 67  499M   67  336M    0     0   137k      0  1:02:00  0:41:46  0:20:14 88702

This is the best we have. It may sometimes fail the ONE download it does, but at least it doesn't explode mid-run on its Nth download of the same.

It has passed now.

Rozzii
Rozzii reviewed Mar 19, 2026
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

metal3-io-bot commented Mar 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rozzii, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Rozzii
Rozzii reviewed Mar 19, 2026
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2026
@metal3-io-bot metal3-io-bot merged commit 5ca944c into metal3-io:release-0.6 Mar 19, 2026
18 checks passed
@metal3-io-bot metal3-io-bot deleted the bump/golangci-lint-v2.6.2-release-0.6 branch March 19, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tuminoid tuminoid tuminoid left review comments

@Rozzii Rozzii Rozzii left review comments

@dtantsur dtantsur Awaiting requested review from dtantsur

@elfosardo elfosardo Awaiting requested review from elfosardo

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

IrSO - v0.6

Development

Successfully merging this pull request may close these issues.

6 participants

@kashifest @Rozzii @dtantsur @tuminoid @metal3-io-bot @nuhakala